Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use size_type in device_uvector definitions when accepting/returning something of size_type #1318

Open
wence- opened this issue Aug 1, 2023 · 0 comments
Labels
0 - Backlog In queue waiting for assignment cpp Pertains to C++ code improvement Improvement / enhancement to an existing function

Comments

@wence-
Copy link
Contributor

wence- commented Aug 1, 2023

device_uvector advertises the type used for the size of the vector as using size_type = std::size_t. But most of the definitions just explicitly spell out std::size_t. We should change these to use size_type (so that things align, and it is easier to change should one want to). This would make the signatures more aligned with those of std::vector as well.

Originally posted by @wence- in #1317 (comment)

@wence- wence- added 0 - Backlog In queue waiting for assignment improvement Improvement / enhancement to an existing function cpp Pertains to C++ code labels Aug 1, 2023
@wence- wence- mentioned this issue Aug 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment cpp Pertains to C++ code improvement Improvement / enhancement to an existing function
Projects
Status: Todo
Development

No branches or pull requests

1 participant