Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate --death-timeout #1017

Closed
jacobtomlinson opened this issue Oct 14, 2022 · 0 comments · Fixed by #1140
Closed

Reinstate --death-timeout #1017

jacobtomlinson opened this issue Oct 14, 2022 · 0 comments · Fixed by #1140

Comments

@jacobtomlinson
Copy link
Member

It looks like the --death-timeout CLI option was removed in #563.

We just had a bug report on dask-cloudprovider about this as we use it there. I'm surprised this hasn't come up in the last 18 months, perhaps folks are pinning to older versions or not using GPUs with dask-cloudprovider and ECS much.

dask/dask-cloudprovider#384

@charlesbluca asked in dask/distributed#4685 about removing this as it appeared to do nothing but James shows an example that suggests it does still function as expected. So should this be reinstated?
@caryr35 caryr35 added this to dask-cuda Dec 8, 2022
@charlesbluca charlesbluca mentioned this issue Mar 13, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Mar 13, 2023
@charlesbluca
Reinstate --death-timeout CLI option (#1140)
ec2de78 
Add back in the `--death-timeout` option removed in #563, along with some tests to verify it's working as expected.

Closes #1017

Authors:
  - Charles Blackmon-Luca (https://github.com/charlesbluca)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #1140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
dask-cuda
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reinstate --death-timeout CLI option charlesbluca/dask-cuda
1 participant
@jacobtomlinson