Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Bulk Sampler Incorrectly Renumbers Batches From 0 Instead of Starting Batch ID #3819

Closed
alexbarghi-nv opened this issue Aug 22, 2023 · 0 comments · Fixed by #3823
Closed

[BUG] Bulk Sampler Incorrectly Renumbers Batches From 0 Instead of Starting Batch ID #3819

alexbarghi-nv opened this issue Aug 22, 2023 · 0 comments · Fixed by #3823
Assignees
@alexbarghi-nv
Labels
bug Something isn't working
Milestone
23.10

Comments

@alexbarghi-nv
Copy link
Member

When loading batches from the bulk sampler that were renumbered to account for empty batches, I noticed that the output batch numbers started from 0 instead of the expected starting batch id, which caused an exception in the cuGraph-PyG reader. This should be corrected.
@alexbarghi-nv alexbarghi-nv added the bug Something isn't working label Aug 22, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.10 milestone Aug 22, 2023
@alexbarghi-nv alexbarghi-nv self-assigned this Aug 22, 2023
@alexbarghi-nv alexbarghi-nv mentioned this issue Aug 24, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Aug 31, 2023
@alexbarghi-nv
[BUG] Fix Batch Renumbering of Empty Batches (#3823)
3922504 
Ensures that batches are renumbered starting from the starting batch id rather than 0.
Adds an appropriate failing test, which passes with the change.
Closes #3819

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Vibhu Jawa (https://github.com/VibhuJawa)
  - Brad Rees (https://github.com/BradReesWork)

URL: #3823
rlratzel pushed a commit to rlratzel/cugraph that referenced this issue Sep 8, 2023
@alexbarghi-nv @rlratzel
[BUG] Fix Batch Renumbering of Empty Batches (rapidsai#3823)
d909d8d 
Ensures that batches are renumbered starting from the starting batch id rather than 0.
Adds an appropriate failing test, which passes with the change.
Closes rapidsai#3819

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Vibhu Jawa (https://github.com/VibhuJawa)
  - Brad Rees (https://github.com/BradReesWork)

URL: rapidsai#3823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbarghi-nv alexbarghi-nv

Labels
bug Something isn't working
Projects
None yet
Milestone
23.10
Development

Successfully merging a pull request may close this issue.

[BUG] Fix Batch Renumbering of Empty Batches alexbarghi-nv/cugraph
1 participant
@alexbarghi-nv