Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACVP test case scraper #4500

Open
randombit opened this issue Dec 26, 2024 · 1 comment
Open

ACVP test case scraper #4500

randombit opened this issue Dec 26, 2024 · 1 comment
Labels
enhancement Enhancement or new feature

Comments

@randombit
Copy link
Owner

Write a script to scrape ACVP test cases in https://github.com/usnistgov/ACVP-Server/tree/master/gen-val/json-files format and insert into our dataset.

@atreiber94
Copy link
Collaborator

atreiber94 commented Jan 2, 2025

We already have a script for ACVP KEM tests in https://github.com/randombit/botan/blob/master/src/scripts/dev_tools/gen_mlkem_acvp_kat.py and use it for ML-KEM. It could be generalized for the other cases.

For PQC, so far the ACVP test cases only cover the "internal" interfaces and give it inputs that are actually not valid. For that reason we did not use the ML-KEM "encapdecap" and any of the PQC DSA ACVP tests because there is no data we can give to Botan's interfaces to arrive at what ACVP tested internally. So for PQC testing I think we should wait for the announced tests for the "external" interfaces that will give us valid data to test.

@randombit randombit added the enhancement Enhancement or new feature label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants