Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] E2E package can’t be imported #981

Open
Danil-Grigorev opened this issue Jan 7, 2025 · 2 comments
Open

[E2E] E2E package can’t be imported #981

Danil-Grigorev opened this issue Jan 7, 2025 · 2 comments

Comments

@Danil-Grigorev
Copy link
Contributor

Danil-Grigorev commented Jan 7, 2025

While importing latest version of e2e package, go mod tidy fails with:

go: github.com/rancher/cluster-api-provider-rke2/turtles-integration-suite-example/suites/import-gitops tested by
        github.com/rancher/cluster-api-provider-rke2/turtles-integration-suite-example/suites/import-gitops.test imports
        github.com/rancher/turtles/test/e2e imports
        github.com/rancher/turtles/exp/etcdrestore/api/v1alpha1: github.com/rancher/turtles/exp/[email protected]: invalid version: unknown revision 000000000000

It seems we only published exp/etcdrestore package once: https://pkg.go.dev/github.com/rancher/turtles/exp/etcdrestore

This may be a problem when people attempt to add a new certified provider and implement e2e suite for it, per the certification process: https://turtles.docs.rancher.com/turtles/v0.15/en/tasks/provider-certification/process.html#_request_for_certification

@furkatgofurov7
Copy link
Contributor

@Danil-Grigorev how can I repro it locally? make verify-modules seems to be running fine locally with latest main branch:

fgofurov@Furkats-MacBook-Pro ~/repos/rancher-turtles  ↱ main  `make verify-modules `
go mod tidy
cd test; go mod tidy
cd exp/etcdrestore; go mod tidy
cd exp/clusterclass; go mod tidy
go: downloading k8s.io/apimachinery v0.28.5
go: downloading k8s.io/client-go v0.28.4
go: downloading sigs.k8s.io/controller-runtime v0.16.3
go: downloading sigs.k8s.io/cluster-api v1.6.1
go: downloading k8s.io/api v0.28.5
go: downloading github.com/onsi/ginkgo/v2 v2.13.1
go: downloading go.uber.org/zap v1.25.0
go: downloading k8s.io/utils v0.0.0-20230406110748-d93618cff8a2
go: downloading github.com/evanphx/json-patch/v5 v5.7.0
go: downloading k8s.io/apiextensions-apiserver v0.28.4
go: downloading k8s.io/component-base v0.28.4
go: downloading golang.org/x/net v0.18.0
go: downloading github.com/prometheus/client_model v0.4.1-0.20230718164431-9a2bf3000d16
go: downloading golang.org/x/oauth2 v0.14.0
go: downloading github.com/google/uuid v1.3.1
go: downloading github.com/benbjohnson/clock v1.3.0
go: downloading golang.org/x/tools v0.14.0
go: downloading golang.org/x/mod v0.13.0
go: downloading k8s.io/apiserver v0.28.4

@Danil-Grigorev
Copy link
Contributor Author

This is an issue for external packages using e2e suite, can be reproduced if github.com/rancher/turtles/exp/etcdrestore import is used in a different project, after running go mod tidy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants