Remove -chart suffix from OBS chart build process #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Mazzotti <[email protected]>
github-actions
bot
added
area/tests
|
I'm actually not sure if we should add a workaround for |
Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
force-pushed
the
fix_obs_chart_name
branch
from
c3218d8
to
a75af70
Compare
If you mean the workaround code, sorry, that was my mistake, it's gone now. |
|
Actually I meant the name change. Apparently, this is a non-issue for helm (and Fleet) but only bothers argocd. So I'd argue this is more of an argocd bug than an elemental-operator bug 🤔 |
|
Indeed seems to be a variant of this: argoproj/argo-cd#13042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #826
But it's most likely going to break a lot of things