Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible performance degradation at edit configmap #9453

Open
Tracked by #9965 ...
Cenness opened this issue Jul 31, 2023 · 6 comments
Open
Tracked by #9965 ...

Possible performance degradation at edit configmap #9453

Cenness opened this issue Jul 31, 2023 · 6 comments

Comments

@Cenness
Copy link

Cenness commented Jul 31, 2023

Setup

  • Rancher version: 2.7.5
  • Rancher UI Extensions: default
  • Browser type & version: Firefox 115

Describe the bug

After updating dashboard from 2.6.1 to 2.7.5 I noticed very long page loading while trying to edit config on configmaps with lots of values. So big, that browser prompts to stop that tab. After pressing tab stop ui is immediately loaded, but values are not editable.

To Reproduce

  1. get k8s cluster
  2. install rancher dashboard
  3. create cm with kv='';for n in $(seq 1 100);do kv="$kv --from-literal=key${n}=config${n}";done;kubectl create configmap big-cm $kv -n default
  4. open it in rancher

Result

default view and edit yaml pages are loaded instantly
edit config ui hangs tab for 30+ seconds

Expected Result

edit config ui loads in less than 10 seconds and allows to edit and save values

Screenshots

N/A

Additional context

Not a frontender, but it sounds like you creating an instance of codemirror editor for each value field?
Adding replicas didn't help, here's metrics:
image

@richard-cox
Copy link
Member

Would you be able to look at the browser's dev tools window's Network tab and provide a screenshot of the requests that have been made? There may be one in there that's stuck on pending or takes a long time to complete

@Cenness
Copy link
Author

Cenness commented Aug 1, 2023

Here:
image
No new requests after loading finishes

Console errors most likely aren't relevant, as they are way before I got to cm. Here latest lines from it:
image

@richard-cox
Copy link
Member

Would you be able to select the XHR tab on the right within the Network tab, hit refresh and post a screenshot of those network requests (might need a couple to show them all)?

Is this only an issue when navigating to the page (if so how many config maps are in the cluster) or also when refreshing?

@Cenness
Copy link
Author

Cenness commented Aug 1, 2023

image

Issue not going away after refreshing. It loads slightly faster after I enabled rancher experimental garbage collection in global settings, but that may be just a wishful thinking.

665 configmaps
5700+ total resources

@richard-cox richard-cox added this to the v2.10.0 milestone May 9, 2024
@richard-cox
Copy link
Member

To be validated against server-side pagination feature. I'm assuming we're fetching all of a resource when we don't need to. Those cases will be removed as part of the pagination feature

@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Sep 27, 2024
@richard-cox richard-cox changed the title Possible performance degradation at edit cm Possible performance degradation at edit configmap Nov 7, 2024
@richard-cox richard-cox modified the milestones: v2.12.0, v2.11.0 Nov 7, 2024
@richard-cox
Copy link
Member

Linking #9965

@richard-cox richard-cox added the size/0.5 Size Estimate 0.5 label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants