Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title of workloads page is "?" #13197

Open
1 task
rak-phillip opened this issue Jan 23, 2025 · 4 comments · May be fixed by #13201
Open
1 task

Title of workloads page is "?" #13197

rak-phillip opened this issue Jan 23, 2025 · 4 comments · May be fixed by #13201
Assignees
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this regression
Milestone

Comments

@rak-phillip
Copy link
Member

rak-phillip commented Jan 23, 2025

The title for the workloads page displays "?" instead of displaying a proper title.

Steps to reproduce

  1. Navigate to Local Cluster explorer => Workloads

Expected behavior

The title of the page is "Workloads"

Actual behavior

The title of the page is "?"

Acceptance criteria

  • The workloads page displays the correct title

Screenshots

Image

@rak-phillip rak-phillip added this to the v2.11.0 milestone Jan 23, 2025
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jan 23, 2025
@richard-cox
Copy link
Member

shell/components/ResourceList/index.vue fails to find schema, so shell/components/ResourceList/Masthead.vue --> _typeDisplay fn returns ?

@richard-cox
Copy link
Member

There's an unconnected override. resource list looks at custom component list straggling method (not in method param)

shell/components/ResourceList/index.vue

      if ( component?.typeDisplay ) {
        this.customTypeDisplay = component.typeDisplay.apply(this);
      }

shell/list/workload.vue. following was removed in one of the pagination PRs

  typeDisplay() {
    const { params:{ resource:type } } = this.$route;
    let paramSchema = schema;

    if (type !== schema.id) {
      paramSchema = this.$store.getters['cluster/schemaFor'](type);
    }

    return this.$store.getters['type-map/labelFor'](paramSchema, 99);
  },

@richard-cox richard-cox linked a pull request Jan 24, 2025 that will close this issue
7 tasks
@richard-cox richard-cox self-assigned this Jan 24, 2025
@richard-cox
Copy link
Member

@rak-phillip make sure to create issues using templates, or manually add the required labels

@rak-phillip
Copy link
Member Author

rak-phillip commented Jan 24, 2025

@richard-cox thanks for the helpful reminder. I raised this issue while deeply investigating another and intended to come back to add common elements like a proper description, repro steps, acceptance criteria, etc..

Moving forward, I think that I will discontinue this practice to avoid inconvenience for others and only raise issues when they are complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants