Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is not shown failures when creating/editing configmap #10794

Closed
richard-cox opened this issue Apr 12, 2024 · 2 comments · Fixed by #11032
Closed

User is not shown failures when creating/editing configmap #10794

richard-cox opened this issue Apr 12, 2024 · 2 comments · Fixed by #11032
Assignees
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this size/2 Size Estimate 2
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Apr 12, 2024

Setup

  • Rancher version: 2.9 pre 2.9.0

Describe the bug

  • If the request to create or edit a configmap fails the user sees a forever Creating/Saving button and is not informed of the issue
  • This seems to only be the case for configmaps. I had a quick look at some others (persistent volume, secrets, pod, storage class) and they were fine

We should check if this was a recent regression or also applies to 2.8

To Reproduce

  • Cluster Explorer --> Storage --> ConfigMap --> Create --> Add $^$^"£% as a name --> Create

Result

  • user is not informed of failure

Expected Result

  • error banner showing description of error. note - there's an existing pattern to convert an error response to an on screen message

Screenshots
image

@richard-cox richard-cox added this to the v2.9.0 milestone Apr 12, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Apr 12, 2024
@gaktive gaktive added size/2 Size Estimate 2 [zube]: Groomed and removed [zube]: Backlog labels Apr 17, 2024
@momesgin momesgin self-assigned this May 14, 2024
@yonasberhe23
Copy link
Contributor

e2e test coverage is sufficient. will move this to done as soon as the below is resolved. cc @izaac

I'm seeing this bug in 2.8, should we backport this? cc @momesgin @richard-cox

@richard-cox
Copy link
Member Author

In hindsight, just 2.9.0 will suffice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this size/2 Size Estimate 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants