Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unauthorized Access to 'Edit Config' Option in Users & Authentication Section for Users Without Sufficient Permissions #10780

Open
aalves08 opened this issue Apr 10, 2024 · 1 comment
Labels
JIRA kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this status/backport-candidate
Milestone

Comments

@aalves08
Copy link
Member

Internal reference: SURE-8160

Setup

  • Rancher version: 2.7.10 (also reproducible in 2.8.3)
  • Rancher UI Extensions: n/a
  • Browser type & version: n/a

Describe the bug

When a non-admin user, whether with a local auth provider or external auth provider, navigates through Rancher UI -> Users&Authentication, he can see his user object there.

If the user clicks on the 'Edit Config' option and tries to edit any value like a password, a permission error is shown to the user.
The 'Edit config' option should not be shown to the users unless they are admins or have the correct permissions.

To Reproduce

Login to the Rancher UI using a local auth user or IDP user and navigate through Rancher UI -> Users&Authentication

After clicking the three dots, the user will see the 'Edit config' option. However, if a user tries to edit anything (password for example), it will show a 'Forbidden: permission denied' error.

Result
A user with insufficient permissions can see the 'Edit config' option for the user object.

Expected Result

The 'Edit config' option for user objects should not be available for users who do not have the right permissions.

Screenshots

repro-2 8 3-system-std-user
repro-2 7 10-system-std-user

Additional context

Happens to users with Global Permissions Standard User and User-Base

@aalves08 aalves08 added this to the v2.9.0 milestone Apr 10, 2024
@github-actions github-actions bot added [zube]: To Triage QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Apr 10, 2024
@aalves08 aalves08 added [zube]: Backlog QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this and removed [zube]: To Triage QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Apr 10, 2024
@aalves08
Copy link
Member Author

aalves08 commented Apr 12, 2024

UPDATE: This will need investigation to see if schemas have the correct information in terms of RBAC. If so, then the proposed UX solution is:

Yes, disabling the Edit functionality for these users is correct. I don't think we need to add any additional information, or banner, etc.

Based on SURE information

@nwmac nwmac modified the milestones: v2.9.0, v2.9.next1 May 7, 2024
@gaktive gaktive modified the milestones: v2.9.next1, v2.10.0 Jul 2, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JIRA kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this status/backport-candidate
Projects
None yet
Development

No branches or pull requests

3 participants