Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this action support multiple branches in a single repository? #15

Open
gep13 opened this issue Oct 2, 2023 · 1 comment
Open

Can this action support multiple branches in a single repository? #15

gep13 opened this issue Oct 2, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@gep13
Copy link

gep13 commented Oct 2, 2023

NOTE: I noticed that your original action had been deprecated, so I thought I would re-ask the question here:

This action looks like it will be really useful, so thank you very much for creating it!

I was a long time user of GitPitch before it closed down, and I am looking to see whether I can use Marp as a replacement.

The way I used to create my GitPitch decks was that I would work off of the master/main branch, and once I gave a presentation I would create a branch at the point that I gave the talk, so that anyone who wanted to review the slide deck for that version of the talk could go back and look at it, and I could continue to tweak/change the slide deck on the master branch.

An example of this can be found here:

https://github.com/gep13-talks/CakeDemos

Is it possible for this action to support the creation of multiple folders in the site that is published to GitHub pages? i.e. a folder for each branch, and then I could give folks a link to the folder to view that version of the slide deck.

Thanks for any help that you can offer here!

@ralexander-phi
Copy link
Owner

Cool workflow!

The action currently deploys any branches that are associated with a pull request, which is intended for a code review scenario:

https://github.com/ralexander-phi/marp-to-pages/blob/main/.github/workflows/marp-to-pages.yml#L63-L69

It should be possible to update the action so that pushing a branch (even one without a PR) will create a folder for the branch. I think that's a reasonable default behavior for this action, so I'd support adding it here.

I'm going to tag this as help-wanted as I don't have the bandwidth to make that change myself but am open to a contribution.

As a possible workaround: You can try tweaking your workflow so that you open a PR each time you give a presentation. The action, as-is, will deploy that to a sub-folder and you can share links to that path.

@ralexander-phi ralexander-phi added the help wanted Extra attention is needed label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants