Code review of SystemSettings code

[christopher-rtf]

Background: MorphicLiteClientWindows is currently using C# code copied or ported from Morphic Classic for getting/setting system/app settings via the Windows SystemSettings infrastructure. This feature is poorly/not documented in Windows, and James indicated that the Morphic Classic team moved away from the C# implementation due to quality concerns.

Task: Analyze the SystemSettings code (by inspecting/introspecting into Windows 10) using tools such as Process Monitor, OleView, Ghidra, etc. Note any inconsistencies between our C# implementation details and inspected Windows implementation details, or any concerns generally.

Based on the MVP10 timeline (beta on 15-May-2020 and RTM on 1-Jun-2020) and because our project direction is to not rewrite the SystemSettings code for MVP10, this analysis is expected to be partial and not full in nature. We should also strongly consider a full analysis.