feat: use InjectedConnector in binance dapp browser #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zane-x-20230331 is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
|
Sorry, I accidentally clicked apply as code owner, please ignore it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DanielSinclair
approved these changes
Jan 23, 2025
|
Looks good to me! Thank you for the concise explanation and clean fix 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the original Binance Wallet configuration,
WalletConnectConnectorwas used for connections in all cases. However, within the built-in browser of Binance Wallet, we provide anInjectedProvider, so usingInjectedConnectoris a better approach. This is because our Android environment currently does not support using WalletConnect within the built-in browser of Binance Wallet, which has caused some users to be unable to connect their wallets in dApps.Bad case video
telegram-cloud-document-5-6089052848677459835.mp4
Modified behaviour video
IMG_9502.mp4