Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise and document object modification methods like shiftlocus #816

Open
rafaqz opened this issue Oct 6, 2024 · 1 comment
Open
Labels
documentation Improvements or additions to documentation

Comments

@rafaqz
Copy link
Owner

rafaqz commented Oct 6, 2024

shiftlocus should be listed here:
https://rafaqz.github.io/DimensionalData.jl/stable/object_modification

It should also have the same syntax as set and other object modification methods. Probably they all need some standardising

@rafaqz rafaqz added the documentation Improvements or additions to documentation label Nov 2, 2024
@rafaqz
Copy link
Owner Author

rafaqz commented Nov 5, 2024

We may be able to roll the user facing-part of rebuild, set, shiftlocus and even reorder into a single function. This should fix everything to match what you specify.

We will then need another function tha updates traits/values without fixing anything else.

Maybe this is set and unsafe_set. I'm not sure. But set can replace rebuild by adding keywords. Then rebuild can be more of the internal thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant