Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support heap-located RIOPlugins #18305

Closed
condret opened this issue Jan 28, 2021 · 1 comment
Closed

Support heap-located RIOPlugins #18305

condret opened this issue Jan 28, 2021 · 1 comment
Assignees
Labels

Comments

@condret
Copy link
Member

condret commented Jan 28, 2021

This relates to radareorg/radare2-rlang#25 .
Problem is that RIOPlugin->open needs to use global-scope in order to access the python objects.
I'd like to fix this by extending RIOPlugin in radare2-rlang and use container_of.
Even then the python wrapper still needs to use global space, to access the plugin-struct itself.
Fix for that would be changing RIOPlugin->open(io, uri, perm, mode) to RIOPlugin->open(io, plugin, url, perm, mode)

@condret condret added the RIO label Jan 28, 2021
@condret condret self-assigned this Jan 28, 2021
condret added a commit to condret/radare2 that referenced this issue Jan 31, 2021
@trufae
Copy link
Collaborator

trufae commented Jan 31, 2021

This is already done and possible, theres no need to modify the api imho. adding one more argument to the open callbacks and check ones makes no sense, the plugin itself knows which is its own plugin, and this is binded into the riodesc

@trufae trufae closed this as completed Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants