Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources.yaml duplicates configuration #21

Open
mattf opened this issue Feb 22, 2017 · 4 comments
Open

resources.yaml duplicates configuration #21

mattf opened this issue Feb 22, 2017 · 4 comments
Labels

Comments

@mattf
Copy link
Member

mattf commented Feb 22, 2017

@elmiko
Copy link
Collaborator

elmiko commented Feb 22, 2017

i'm not following what the action here is, should we be using the upstream blobs or does resources.yaml need a refactoring?

@mattf
Copy link
Member Author

mattf commented Feb 22, 2017

my goal was to record this tech debt. how/if it should be resolved is unclear.

@elmiko
Copy link
Collaborator

elmiko commented Feb 22, 2017

ack, thanks

@elmiko
Copy link
Collaborator

elmiko commented Mar 15, 2018

as we have now updated the template from the s2i repo to resource.yaml a few times, i think we have more resolution on this.

one of the issues with bringing the templates from the oshinko-s2i is that there are minor differences that we employ in the resources.yaml from the strict upstream templates. i think we might want to think about generating the resources.yaml inside the s2i repo and then copying to here.

alternatively, we could investigate the idea of having a template generator once again (ie radleyberg).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants