Fix errors and implement possible improvements arising from my suggestions for the paper

[eugenividal]

• In the README:

• Rephrase the paragraph explaining the different versions of the data, as it is in the suggestions for the paper

• Given that the title is done with one #, add one level (i.e. ##) to the headings 1.

• plot the desire lines using the flow mapper.

• Remove the title of the first figure --- there is already a caption with title for this figure.

• Beautify Figure 4, checking for typos (e.g. munucipality, houlry), putting the first three boxes at the same level, etc.

• In the vignettes:

• the name of the mobility datasets could be clearer, specially '2.2. Number of trips data'. Rename them as follows:

   + Version 1, Mobility data:  
        - Origin-Destination data
        - Population by trip count data 
  
   +  Version 2, Mobility data:
         - Origin-Destination data
         - Population by trip count data
         - Population by overnight stay data
  

• In the package:

• Fix inconsistencies in the name of the variables of the different versions: e.g. date and full_date, and residence_province_name and residence_province.

• I'd consider renaming some variables: E.g. time slot = hour_slot and distance = interval_distance

[Robinlovelace]

Great set of suggestions Eugeni, here are my thoughts:

• Rephrase the paragraph explaining the different versions of the data: sounds good! The README can be concise so no need to include all the detail but agree that rephrasing the paragraph is a good idea.

• Given that the title is done with one #, add one level (i.e. ##) to the headings 1.

👍

• Not sure if @Robinlovelace will be happy with this, but for consistency, perhaps it may be better to plot the desire lines also using the flow mapper.

I vote keeping the use of the {od} package to show a wider range of use cases. Geographic desire lines can be useful

• Remove the title of the first figure --- there is already a caption with title for this figure.

👍

And 👍 to all the others!

[Robinlovelace]

And to the offer of updates 👍

[e-kotov]

1. @eugenividal sure, go on with the PR

• Not sure if @Robinlovelace will be happy with this, but for consistency, perhaps it may be better to plot the desire lines also using the flow mapper.

I vote keeping the use of the {od} package to show a wider range of use cases. Geographic desire lines can be useful

@Robinlovelace I think @eugenividal only suggested to plot the desire lines with {flowmapper}, that does not mean removing {od}. Or are you worried that plotting with {flowmapper} would 'hide' most of the desire lines with low trip counts?

[Robinlovelace]

No objections to plotting the desire lines with {flowmapper}. Would make the figures in the README more consistent.

[eugenividal]

only suggested to plot the desire lines with {flowmapper}

Exactly!

I'll carry on with this PR another day. I got distracted with another study.