You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
...since the main issue in this release will be build failures related to (1) lack of cmake or (2) lack of (a sufficient version of system) Abseil or (3) patches required to vendored Abseil to avoid check failures with compilers we haven't thought of yet.
# docker run --rm -it -v `pwd`/check:/check ghcr.io/r-hub/containers/atlas:latest bash
# # dnf install cmake
# # r-check
Found the following significant warnings:
/check/s2.Rcheck/00_pkg_src/s2/tools/vendor/abseil-cpp/absl/container/internal/raw_hash_set.h:577:40: warning: overflow in conversion from ‘int’ to ‘char’ changes value from ‘128’ to ‘-128’ [-Woverflow]
../src/s2/util/gtl/compact_array.h:127:28: warning: ISO C++ forbids zero-size array [-Wpedantic]
/check/s2.Rcheck/00_pkg_src/s2/tools/dist/include/absl/container/internal/raw_hash_set.h:577:40: warning: overflow in conversion from ‘int’ to ‘char’ changes value from ‘128’ to ‘-128’ [-Woverflow]
../src/s2/s2region_coverer.h:275:25: warning: ISO C++ forbids zero-size array ‘children’ [-Wpedantic]
s2/s2region_coverer.h:275:25: warning: ISO C++ forbids zero-size array ‘children’ [-Wpedantic]
See ‘/check/s2.Rcheck/00install.out’ for details.
I'm fairly sure we fixed the zero-size array thing in the previous version and can patch the raw_hash_set in the vendored Abseil.
Prepare for release:
git pull
urlchecker::url_check()
devtools::build_readme()
devtools::check(remote = TRUE, manual = TRUE)
devtools::check_win_devel()
revdepcheck::revdep_check(num_workers = 4)
cran-comments.md
git push
Submit to CRAN:
usethis::use_version('minor')
devtools::submit_cran()
Wait for CRAN...
usethis::use_github_release()
usethis::use_dev_version(push = TRUE)
The text was updated successfully, but these errors were encountered: