Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release s2 1.2.0 #266

Open
3 of 20 tasks
paleolimbot opened this issue Jan 15, 2025 · 2 comments
Open
3 of 20 tasks

Release s2 1.2.0 #266

paleolimbot opened this issue Jan 15, 2025 · 2 comments

Comments

@paleolimbot
Copy link
Collaborator

paleolimbot commented Jan 15, 2025

Prepare for release:

  • git pull
  • Check current CRAN check results
  • Polish NEWS
  • urlchecker::url_check()
  • devtools::build_readme()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • revdepcheck::revdep_check(num_workers = 4)
  • Update cran-comments.md
  • git push
  • Draft blog post

Submit to CRAN:

  • usethis::use_version('minor')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • Finish & publish blog post
  • Add link to blog post in pkgdown news menu
  • usethis::use_github_release()
  • usethis::use_dev_version(push = TRUE)
  • Share on social media
@paleolimbot
Copy link
Collaborator Author

In addition to these steps, we should run through the list of containers here: https://r-hub.github.io/containers/

...since the main issue in this release will be build failures related to (1) lack of cmake or (2) lack of (a sufficient version of system) Abseil or (3) patches required to vendored Abseil to avoid check failures with compilers we haven't thought of yet.

@paleolimbot
Copy link
Collaborator Author

paleolimbot commented Jan 21, 2025

atlas (Fedora 38) gives:

# docker run --rm -it -v `pwd`/check:/check ghcr.io/r-hub/containers/atlas:latest bash
# # dnf install cmake
# # r-check
Found the following significant warnings:
  /check/s2.Rcheck/00_pkg_src/s2/tools/vendor/abseil-cpp/absl/container/internal/raw_hash_set.h:577:40: warning: overflow in conversion from ‘int’ to ‘char’ changes value from ‘128’ to ‘-128’ [-Woverflow]
  ../src/s2/util/gtl/compact_array.h:127:28: warning: ISO C++ forbids zero-size array [-Wpedantic]
  /check/s2.Rcheck/00_pkg_src/s2/tools/dist/include/absl/container/internal/raw_hash_set.h:577:40: warning: overflow in conversion from ‘int’ to ‘char’ changes value from ‘128’ to ‘-128’ [-Woverflow]
  ../src/s2/s2region_coverer.h:275:25: warning: ISO C++ forbids zero-size array ‘children’ [-Wpedantic]
  s2/s2region_coverer.h:275:25: warning: ISO C++ forbids zero-size array ‘children’ [-Wpedantic]
See ‘/check/s2.Rcheck/00install.out’ for details.

I'm fairly sure we fixed the zero-size array thing in the previous version and can patch the raw_hash_set in the vendored Abseil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant