Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should matches use perl = TRUE? #330

Closed
hadley opened this issue Nov 7, 2022 · 1 comment · Fixed by #366
Closed

Should matches use perl = TRUE? #330

hadley opened this issue Nov 7, 2022 · 1 comment · Fixed by #366

Comments

@hadley
Copy link
Member

hadley commented Nov 7, 2022

I doubt this will affect any existing code, but does make the pattern syntax a bit closer to stringr.

@ant-durrant
Copy link

I just came here to check whether \p{} not being supported was possibly a bug and saw that perl = FALSE is the culprit.

Put that as at least one vote for yes!

From the docs:

For matches() this is a regular expression, and can be a stringr pattern.

I am aware that using grep() sub() I have to think about a perl flag, but I am not aware of ever thinking about it when using tidyverse stuff.

Just checked, and yep - at least stringr::str_detect() does not have perl as an argument, so if it is to be included, having the default as TRUE makes sense for me.

lionel- added a commit that referenced this issue Oct 25, 2024
lionel- added a commit that referenced this issue Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants