From 42f32e73c69cecaaa00a9ab64653cf36f35f995e Mon Sep 17 00:00:00 2001 From: Matt Nield <64328730+matthewjnield@users.noreply.github.com> Date: Tue, 22 Oct 2024 09:55:18 -0400 Subject: [PATCH] Fix grammar in warning about bare predicates (#349) --- R/eval-walk.R | 2 +- tests/testthat/_snaps/eval-walk.md | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/R/eval-walk.R b/R/eval-walk.R index b9c9121d..b30bc0e7 100644 --- a/R/eval-walk.R +++ b/R/eval-walk.R @@ -422,7 +422,7 @@ eval_sym <- function(expr, data_mask, context_mask, strict = FALSE) { # Formally deprecated in 1.2.0 lifecycle::deprecate_soft("1.1.0", what = I("Use of bare predicate functions"), - with = I("wrap predicates in `where()`"), + with = I("`where()` to wrap predicate functions"), details = c( " " = "# Was:", " " = glue("data %>% select({name})"), diff --git a/tests/testthat/_snaps/eval-walk.md b/tests/testthat/_snaps/eval-walk.md index 78d80c3d..737c3b89 100644 --- a/tests/testthat/_snaps/eval-walk.md +++ b/tests/testthat/_snaps/eval-walk.md @@ -91,7 +91,7 @@ Condition Warning: Use of bare predicate functions was deprecated in tidyselect 1.1.0. - i Please use wrap predicates in `where()` instead. + i Please use `where()` to wrap predicate functions instead. # Was: data %>% select(is_integer) @@ -102,7 +102,7 @@ Condition Warning: Use of bare predicate functions was deprecated in tidyselect 1.1.0. - i Please use wrap predicates in `where()` instead. + i Please use `where()` to wrap predicate functions instead. # Was: data %>% select(is.numeric) @@ -113,7 +113,7 @@ Condition Warning: Use of bare predicate functions was deprecated in tidyselect 1.1.0. - i Please use wrap predicates in `where()` instead. + i Please use `where()` to wrap predicate functions instead. # Was: data %>% select(isTRUE) @@ -125,7 +125,7 @@ Condition Warning: Use of bare predicate functions was deprecated in tidyselect 1.1.0. - i Please use wrap predicates in `where()` instead. + i Please use `where()` to wrap predicate functions instead. # Was: data %>% select(is_integer)