Custom navbar config needs to reference the search bar

[maelle]

it used not to, the change is due to #2449

https://mastodon.social/@sebffischer/112954449837337953

[jayhesselberth]

Do you mean that previously if you had a custom navbar config but didn't include search, it would be included in the navbar anyway? If so, then the new behavior is actually more consistent with the documentation. Bummer it affects lots of sites though.

FWIW this was an unintentional "fix".

Can you link to a site that was affected by this change?

[maelle]

Do you mean that previously if you had a custom navbar config but didn't include search, it would be included in the navbar anyway?

yes!

One example: https://github.com/ropensci/targets/pull/1303/files (more linked from ropensci-org/rotemplate#112)

[hadley]

I knew this was going to happen so I must have failed to advertise it enough 😞