Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: 1password backend #123

Open
nbenn opened this issue Mar 28, 2022 · 4 comments
Open

Feature request: 1password backend #123

nbenn opened this issue Mar 28, 2022 · 4 comments
Labels
feature a feature request or enhancement

Comments

@nbenn
Copy link
Contributor

nbenn commented Mar 28, 2022

I recently became aware that the password manager of my choice, 1password, offered a command line tool. Now this, I'm sure is closed source code, but maybe a backend implementation using system calls could be done?

This is a low priority thing for me currently, but if there is interest around, I would consider putting together a PR for such an extension in the medium term.

@gaborcsardi, how would you feel about such a feature?

@gaborcsardi
Copy link
Member

I am not using it myself, and if it is low priority for you, then I am worried about long term maintenance.

@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Mar 28, 2022
@nbenn
Copy link
Contributor Author

nbenn commented Mar 28, 2022

It's low priority b/c I'm not using this myself currently. But I could see myself using it in the future, which is why I made the suggestion. As such, I could also see myself providing some maintenance support if the need arises. Of course I cannot make any promises and also, this interfacing with a closed source, for profit app, we'd have no control over what direction they choose to take their product in the future.

I just wanted to see how you feel about this @gaborcsardi, before properly starting to think about how/when/etc. It's also fine with me if you're skeptical and don't see this becoming part of keyring.

@gaborcsardi
Copy link
Member

I don't mind adding it, hopefully we can find some users. Some concerns:

  • It might not be easy or even possible to use their cli client w/o a terminal. It would be reasonable if they didn't allow it. This is something to try.
  • Using system() cross-platform is a pain in the neck, but we can use sys, which we already depend on indirectly, or processx would be fine as well.

@jimjam-slam
Copy link

jimjam-slam commented Jul 26, 2022

I've used the 1Password CLI in the past to inject secrets into things like Docker containers as environment variables. I believe they've since expanded those tools with 1 Password 8 to include things like an SSH agent, sending secrets directly to CI infrastructure, etc (not sure if the old API is still available!). So you'd probably want to think about the scope of such an integration. But I'd personally be excited for it, as I use 1P to handle this stuff rather than my system backend 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants