Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow source handler to control source #125

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Allow source handler to control source #125

merged 2 commits into from
Jun 5, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Jun 4, 2024

No description provided.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok (except for small comment below)

I don't think this will have impact on knitr. I can run test suite with all our example against this PR if you want me to check.

R/eval.R Outdated Show resolved Hide resolved
@hadley
Copy link
Member Author

hadley commented Jun 5, 2024

This has been designed to have no impact on existing code, but I think it would be worth double checking that before release, if it's not too much trouble.

@hadley hadley merged commit 2d36600 into main Jun 5, 2024
13 checks passed
@hadley hadley deleted the control-output branch June 5, 2024 13:04
@cderv
Copy link
Collaborator

cderv commented Jun 6, 2024

I did the testing in knitr repo, and dev version of evaluate does not have any impact. All good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants