Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website code is difficult to read in dark mode #522

Open
jonbry opened this issue Sep 26, 2024 · 6 comments
Open

Website code is difficult to read in dark mode #522

jonbry opened this issue Sep 26, 2024 · 6 comments

Comments

@jonbry
Copy link

jonbry commented Sep 26, 2024

Not sure if this is the right place to post this, but I noticed that the website is a bit difficult to read if the computer is set to dark mode:

For comparison, here's an example of pkgdown's website, which is much easier to read:

I had no issue if I switched my computer/phone to light mode.

@krlmlr
Copy link
Member

krlmlr commented Sep 26, 2024

Thanks. What browser do you use? This looks okay to me in Firefox's Dark Mode Reader, but certainly could be improved.

CC @maelle.

image

@jonbry
Copy link
Author

jonbry commented Sep 27, 2024

What browser do you use?

Thanks for the quick reply! The screenshots are of Firefox (Ubuntu). I got the same results on Safari for both iOS and macOS.

It looks like the main page is ok, but the Articles and References might be different. Here's what I see for Write a local data frame or file to database with Safari (iOS):
image

@krlmlr
Copy link
Member

krlmlr commented Sep 27, 2024

Looks good on Firefox, terrible on Safari, on my machine. I wonder what's going on.

@maelle
Copy link
Contributor

maelle commented Oct 7, 2024

Reminds me of r-lib/pkgdown#2732

@maelle
Copy link
Contributor

maelle commented Oct 7, 2024

I'm realizing that dbitemplate does not provide dark mode, let me fix that.

@maelle
Copy link
Contributor

maelle commented Oct 7, 2024

r-dbi/dbitemplate#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants