Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc Update] Tutorial about Building and Executing Queries with Objects #253

Closed
alex-au-922 opened this issue Apr 25, 2024 · 3 comments
Closed

Comments

@alex-au-922
Copy link
Contributor

Currently we have a lot of implemented methods regarding the issue #20 and I think we should have a proper documentation for parameters accepted and usecases.

yep agree 💯

should we add a new section under Building and Executing Queries

Your suggestions lead me in the direction of:

  • we rename the existing Building and Executing Queries to Building and Executing Queries with the Query Parser
  • add a new tutorial called Building and Executing Queries with the Query Objects, where we can add tutorial content using the new objects.

What do you think?

We can merge this PR first anyway, and do such docs in a different PR.

Originally posted by @cjrh in #250 (comment)

@alex-au-922
Copy link
Contributor Author

I think this can definitely introduce users with more advanced usage of the Query Object in case some of the query cannot be parsed with the Query Parser, as mentioned by @cjrh in #250.

But seems a tutorial on the use of Query Objects cannot be very comprehensive (they might fall asleep when reading large chunk of function signatures definitely), will we open another page for the documentation, or just let the user reference the rust version of the equivalent queries?

@cjrh
Copy link
Collaborator

cjrh commented Apr 25, 2024

We will eventually have API documentation in the Reference section of the docs. I'm working on that in another PR.

A really good tutorial would be the example you gave in that other issue, using BooleanQuery and the nested disjunction query. The tutorial doesn't have to be, and probably shouldn't be comprehensive. The main goal is to teach something.

@cjrh
Copy link
Collaborator

cjrh commented Apr 26, 2024

The PR was merged so closing

@cjrh cjrh closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants