Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Leave/Join #30

Open
evanxg852000 opened this issue Mar 14, 2022 · 1 comment
Open

Implement Leave/Join #30

evanxg852000 opened this issue Mar 14, 2022 · 1 comment

Comments

@evanxg852000
Copy link
Collaborator

evanxg852000 commented Mar 14, 2022 •
edited
Loading

We probably need to implement a leave/join method for a node.

  • Leave: stops the node from gossiping to others, stops processing gossip messages
  • Join: puts back the node in normal mode
    These should be useful for exposing on the gRPC service.

Currently, we have shutdown that stops the UpdServer and consumes the server.

@fulmicoton WDYT? https://github.com/quickwit-oss/quickwit/pull/1164/files#diff-5f02eaf8b40edf6dfb71eab3ea3c59888c42f987d19b1934b9c03bc176f4ec50R191
@fulmicoton
Copy link
Contributor

Let's add it when we need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evanxg852000 @fulmicoton