Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace return with warn! in server loop #146

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Replace return with warn! in server loop #146

wants to merge 1 commit into from

Conversation

cattuz
Copy link

@cattuz cattuz commented Mar 30, 2024

The return causes the server to stop and all gossiping to end whenever a node leaves on windows. Each node which fails to communicate with the exited node will then stop gossiping.

Attempts to fix #145

Replace return with warn! in server loop
975fe35 
The return causes the server to stop and all gossiping to end whenever a node leaves on windows. Each node which fails to communicate with the exited node will then stop gossiping.
@cattuz cattuz mentioned this pull request Mar 30, 2024
Open
@cattuz cattuz changed the title Replace return with warn! in server loop Replace return with warn! in server loop Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird behavior when running tests
1 participant
@cattuz