Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Color, Intensity etc. from ansi-terminal #233

Open
georgefst opened this issue Aug 28, 2022 · 3 comments
Open

Use Color, Intensity etc. from ansi-terminal #233

georgefst opened this issue Aug 28, 2022 · 3 comments

Comments

@georgefst
Copy link
Contributor

Is there any particular reason why prettyprinter-ansi-terminal redefines its own versions of these types, isomorphic to the ones upstream? I often find myself needing to resolve conflicting imports due to this, especially since the ones from this package are re-exported through pretty-simple.

@georgefst
Copy link
Contributor Author

Ah, I've just seen this has previously been asked by @sjakobi (no response): #121 (comment).

@sjakobi
Copy link
Collaborator

sjakobi commented Aug 30, 2022

Is there any particular reason why prettyprinter-ansi-terminal redefines its own versions of these types, isomorphic to the ones upstream?

I speculated about this in #224 (comment):

I'm not sure, but I suspect that the local types exist so the internals can be changed with less compatibility hassle. Re-exports also bring their own versioning problems.

Maybe @quchen can comment on the original motivation.

@georgefst
Copy link
Contributor Author

I'm not sure, but I suspect that the local types exist so the internals can be changed with less compatibility hassle. Re-exports also bring their own versioning problems.

I can't really see either of those having much bearing in practice, particularly given how unlikely the ANSI standard is to change any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants