-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating project's jackson version causes container creation to fail #13635
Comments
/cc @geoand |
Could you add the I suspect one of the reasons it's failing is because the Jib extension doesn't depend on |
It's not enough. Looks like we will need to customize the |
Pffff... That sucks really... |
It should probably be reported to the Jib project. They will probably figure it out when upgrading Jackson. What I don't understand though is that the JSR 310 extension has a service file pointing to the module so I would have expected Jackson to register it automatically? |
Great idea! @laurentgo would you like to do that?
IIRC, in Jackson you need to call a method in order for it to find modules, I don't think it does it automatically. |
Yeah, I don't see why the service files, then :). But I can live with this mystery :). |
There's no automatic registration of module by default (probably for backward compatibility with existing code registering modules manually?), but if desired, one can use |
That's my plan, but the reason why I opened this bug in the first place was to understand why changing jackson version of my project would impact generating the docker image, and if there's something to be done in quarkus about it. |
We don't deal with the ObjectMapper that Jib uses at all. We probably could if we wanted to, but I would prefer not to unless it's absolutely necessary. |
I was not thinking of changing |
Most likely your update to Jackson breaks what Jib expects for Jackson. |
But is it expected that a code dependency update breaks a build/tool dependency? For regular maven project, it would be a bug if changing a code dependency would break the jar plugin for example... |
fyi proposed patch for Jib: GoogleContainerTools/jib#2908 |
Closing as GoogleContainerTools/jib#2908 has been merged |
Describe the bug
When updating jackson's version in a Maven project using quakus, build failed when building the container.
From https://github.com/projectnessie/nessie/runs/1475113588?check_suite_focus=true:
This seems to also impact quarkus itself in #13570:
Originally posted by @gsmet in #13570 (comment)
Expected behavior
The build should have succeeded and docker image created
Actual behavior
build fails during image creation
To Reproduce
Link to a small reproducer (preferably a Maven project if the issue is not Gradle-specific).
Or attach an archive containing the reproducer to the issue.
Steps to reproduce the behavior:
quarkus-container-image-jib
extensionquarkus.container-image.build
property set to trueEnvironment (please complete the following information):
uname -a
orver
: Darwin Laurents-MBP.local 18.7.0 Darwin Kernel Version 18.7.0: Mon Aug 31 20:53:32 PDT 2020; root:xnu-4903.278.44~1/RELEASE_X86_64 x86_64 (can reproduce on Linux too)java -version
:mvnw --version
orgradlew --version
):Additional context
The visible issue seems to be caused by Jib project not importing the Jackson jsr310 module which is now "required" by Jackson 2.12. But there might be a separate issue regarding Quarkus as it seems that build extensions are directly impacted by changes in project dependencies, whereas Maven plugins usually have their own dependency management.
The text was updated successfully, but these errors were encountered: