Some issues with printing a TComplexity that has symbolic parameters

[wjhuggins]

I get an error I don't understand when trying to print a TComplexity with symbolic parameters. Here is a minimal example:

from sympy import Symbol

import cirq

from qualtran.bloqs.mcmt import MultiControlPauli
from qualtran.symbolics import HasLength
from qualtran.cirq_interop.t_complexity_protocol import t_complexity

ccpauli_symb = MultiControlPauli(cvs=HasLength(Symbol("k", integer=True, positive=True)), target_gate=cirq.X)

print(t_complexity(ccpauli_symb))

Running this code produces the following error message:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-1-8e9cf3d259d8> in <cell line: 11>()
      9 ccpauli_symb = MultiControlPauli(cvs=HasLength(Symbol("k", integer=True, positive=True)), target_gate=cirq.X)
     10 
---> 11 print(t_complexity(ccpauli_symb))

1 frames
/usr/local/lib/python3.10/dist-packages/qualtran/cirq_interop/t_complexity_protocol.py in __str__(self)
     67     def __str__(self) -> str:
     68         return (
---> 69             f'T-count:   {self.t:g}\n'
     70             f'Rotations: {self.rotations:g}\n'
     71             f'Cliffords: {self.clifford:g}\n'

/usr/local/lib/python3.10/dist-packages/sympy/core/expr.py in __format__(self, format_spec)
    381                 if rounded.is_Float:
    382                     return format(rounded, format_spec)
--> 383         return super().__format__(format_spec)
    384 
    385     @staticmethod

TypeError: unsupported format string passed to Add.__format__

[tanujkhattar]

Yeah, that's because of the ":g" in the __str__ implementation, which assumes the fields to be floats / ints. Printing individual fields as sympy expressions should work fine -- print(t_complexity(ccpauli_symb).t)

This issue should be fixed though. I've also run into this in the past. Thanks for opening an issue!

[wjhuggins]

Sure. I've been using
.asdict() to make it print but I figured it was worth flagging.