Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct lint issues exposed with update to pylint-3 #1440

Open
pavoljuhas opened this issue Oct 5, 2024 · 0 comments
Open

Correct lint issues exposed with update to pylint-3 #1440

pavoljuhas opened this issue Oct 5, 2024 · 0 comments
Labels
devops
Milestone
After v1.0

Comments

@pavoljuhas
Copy link
Contributor

pylint-3 has some default rules which currently fail.
These were temporarily disabled in .pylintrc to pass the CI for #1439.

Consider enabling them back with associated code fixups (see TODO in .pylintrc).
@pavoljuhas pavoljuhas mentioned this issue Oct 7, 2024
Merged
pavoljuhas added a commit that referenced this issue Oct 7, 2024
@pavoljuhas
Update copyright checker and switch to pylint-3 (#1439)
b0ef177 
* Bump up to the latest pylint-3.3.1

* Adjust `pylint_copyright_checker` for the pylint-3 API
  Follow the `examples/custom_raw.py` in the pylint repository.

* Refresh development dependencies

* Temporarily disable rules that started failing in pylint-3

Cherry-picked from quantumlib/Cirq#6751
Related to #1440
shab5 pushed a commit that referenced this issue Oct 7, 2024
@pavoljuhas @shab5
Update copyright checker and switch to pylint-3 (#1439)
96dc7fe 
* Bump up to the latest pylint-3.3.1

* Adjust `pylint_copyright_checker` for the pylint-3 API
  Follow the `examples/custom_raw.py` in the pylint repository.

* Refresh development dependencies

* Temporarily disable rules that started failing in pylint-3

Cherry-picked from quantumlib/Cirq#6751
Related to #1440
@mpharrigan mpharrigan added this to the After v1.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devops
Projects
None yet
Milestone
After v1.0
Development

No branches or pull requests
2 participants
@pavoljuhas @mpharrigan