Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing date information #69

Open
pagelj opened this issue May 28, 2019 · 3 comments
Open

Missing date information #69

pagelj opened this issue May 28, 2019 · 3 comments
Assignees
Milestone

Comments

@pagelj
Copy link
Member

pagelj commented May 28, 2019

Some of the dates in the metadata table (like written, premier etc.) are not being exported anymore

@pagelj pagelj added the bug label May 28, 2019
@pagelj pagelj added this to the 2.1.0 milestone May 28, 2019
@pagelj pagelj self-assigned this May 28, 2019
@pagelj
Copy link
Member Author

pagelj commented May 28, 2019

This issue occurs when the date is not explicitly given as text, e.g.

<date type="print" when="1888">1888</date>

will be exported but

<date type="printed" when="1888"/>

won't

An example is https://github.com/quadrama/gerdracor/blob/quadrama/data/1871-Anzengruber_Ludwig-Der_Meineidbauer-lina.xml

@pagelj
Copy link
Member Author

pagelj commented May 28, 2019

@pagelj pagelj removed the bug label Jun 7, 2019
@pagelj pagelj closed this as completed Jun 7, 2019
@pagelj
Copy link
Member Author

pagelj commented Apr 24, 2020

This get's fixed by nilsreiter/generic-xml-reader@0f8c085, but generic-xml-reader version 1.6 requires a higher DKpro version as is currently used in DramaNLP. Unfornuately, updating to this DKpro version is not trivial, so this will be postponed until nilsreiter/generic-xml-reader#12 and #45 have been resolved

@pagelj pagelj reopened this Apr 24, 2020
@pagelj pagelj modified the milestones: 2.1.0, 3.0.0 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant