Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlTestSuite - svg attributes with mixed case #32

Open
michaelhkay opened this issue Dec 31, 2022 · 7 comments
Open

HtmlTestSuite - svg attributes with mixed case #32

michaelhkay opened this issue Dec 31, 2022 · 7 comments

Comments

@michaelhkay
Copy link
Contributor

In the expected results for the new HtmlTestSuite test set, the case of SVG attributes has been forced to lower case. I believe this is incorrect. For example in test-0017, attributeName has been changed to attributename. I believe the correct procedure is first to normalise to lower-case, then to apply the rules for "adjust SVG attributes" in §13.4.6.1 of the HTML5 spec, which convert sttributename to attributeName.

@michaelhkay
Copy link
Contributor Author

Fixed the test generator (based on JSoup) to do this.

@michaelhkay
Copy link
Contributor Author

Also: in tests such as test-0580, JSoup is converting the element:

<ruby>
  <rbc><rb>新</rb><rb>幹</rb><rb>線</rb></rbc>
  <rtc><rt>しん</rt><rt>かん</rt><rt>せん</rt></rtc>
</ruby>

into:

<ruby>
  <rbc><rb>新</rb><rb>幹</rb><rb>線</rb></rbc>
  <rtc/><rt>しん</rt><rt>かん</rt><rt>せん</rt>
</ruby>

I can't see why it would do this: neither Chrome nor Safari does so.

@michaelhkay
Copy link
Contributor Author

This appears to have been reported as an issue by @rhdunn at jhy/jsoup#1294 but I'm not sure why there's a problem in the version I'm using - jsoup 1.15.3.

@michaelhkay
Copy link
Contributor Author

Affects tests 0580 and 0587. Perhaps we should just fix them "by hand".

@GuntherRademacher
Copy link
Contributor

Fixed the test generator (based on JSoup) to do this.

@michaelhkay Did you possibly not push that change? I was trying to reproduce the contents of the results folder from the files folder using the generateXhtml tool (with the intent to later adapt it for #57), but I am getting different results, including SVG attribute names in lower case where results have them in mixed case.

Please find the result differences in my fork here.

Concerning the other differences, could their cause be me using a different Saxon version? I used org.jsoup:jsoup:1.15.3 and net.sf.saxon:Saxon-HE:12.3. Also added a Gradle project to generateXhtml.

@michaelhkay
Copy link
Contributor Author

There's been a fair bit of water flowing under the bridge since that previous comment, and I'm aware that it's still an open issue.

@michaelhkay
Copy link
Contributor Author

I'm sorry, I haven't made any progress in exploring the history here. I've fixed the expected results for SVG elements that should be in mixed case, but I haven't revisited the test generator and it's not on my current list of priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants