Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt3scan: review and possibly move location of 'show_optimization_plot' method. #73

Open
gadamc opened this issue Jan 31, 2023 · 0 comments
Open

qt3scan: review and possibly move location of 'show_optimization_plot' method. #73

gadamc opened this issue Jan 31, 2023 · 0 comments
Labels
code organization Issues that do not change functionality or fix bugs, but organize the code in more logical manner GUI work this work involves GUI components

Comments

@gadamc
Copy link
Collaborator

gadamc commented Jan 31, 2023

Currently, show_optimization_plot, is a method of the main application view. This function is called by the main_application app (the controller in the model-view-controller design paradigm) after running the optimization routine (which optimizes the position by searching for maximal count rate).

This function creates a new window to display the optimization. Should this function actually exist inside of the main_application controller?
@gadamc gadamc added GUI work this work involves GUI components code organization Issues that do not change functionality or fix bugs, but organize the code in more logical manner labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code organization Issues that do not change functionality or fix bugs, but organize the code in more logical manner GUI work this work involves GUI components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gadamc