Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename remaining pulse 'width' parameters to 'pulse_duration' #64

Open
gadamc opened this issue Nov 11, 2022 · 0 comments
Open

rename remaining pulse 'width' parameters to 'pulse_duration' #64

gadamc opened this issue Nov 11, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@gadamc
Copy link
Collaborator

gadamc commented Nov 11, 2022

Previously we've changed the 'rf_width' variable name to 'rf_pulse_duration' as requested. However, the variables for other channels still use "width", such as "aom_width" and "trigger_width". We should change the names of these values to "X_pulse_duration" as well for consistency

@gadamc gadamc added the good first issue Good for newcomers label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant