Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: scatterplot-2d: Enable Zoom In/Out and Dynamic Resizing of Plot #35

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

ENH: scatterplot-2d: Enable Zoom In/Out and Dynamic Resizing of Plot #35

wants to merge 1 commit into from

Conversation

ChristosMatzoros
Copy link
Contributor

This PR provides a solution for the enhancement described in issue #34.

It introduces zoom functionality, allowing users to zoom in and out based on the cursor's position. Additionally, the plot automatically resizes based on the window size, improving usability and preventing unnecessary scrolling.

@lizgehret lizgehret self-assigned this Sep 17, 2024
@lizgehret lizgehret linked an issue Sep 17, 2024 that may be closed by this pull request
IMP: Enable Zoom In/Out and Dynamic Resizing of scatterplot #34
Open
@lizgehret
Copy link
Member

Hey @ChristosMatzoros,

Thanks for submitting this PR! I did some user testing, and I think this all works quite well. A couple of things:

  1. I'm going to push up some name changes to the signals and scales you've added into the spec so that everything matches with the rest of my naming structures in vizard.
  2. I'd like to ask that you move the functionality for the auto resizing to a separate PR - I think this is awesome, and is definitely something I'd like to have in all of the visualizations, but realistically I'll need to add that in post-2024.10. I don't want this to just be something that's available in one visualization, but not all of them - and need to prioritize finishing up the core functionality in vizard for its initial release.

Thanks again for these contributions, let me know if you have any questions!

@hagenjp hagenjp assigned lizgehret and unassigned ChristosMatzoros Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lizgehret lizgehret

Labels
None yet
Projects
QIIME 2 - Approved but unscheduled ✅
Status: PRs - Improvement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IMP: Enable Zoom In/Out and Dynamic Resizing of scatterplot
2 participants
@ChristosMatzoros @lizgehret