Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple workspace types per scheduler #590

Open
d4l3k opened this issue Aug 25, 2022 · 2 comments
Open

Support multiple workspace types per scheduler #590

d4l3k opened this issue Aug 25, 2022 · 2 comments
Labels
enhancement New feature or request module: runner issues related to the torchx.runner and torchx.scheduler modules

Comments

@d4l3k
Copy link
Member

d4l3k commented Aug 25, 2022

Description

Currently a scheduler is tied to a specific image type. Some schedulers such as LSF (and Slurm) support multiple different types of images. Ideally we could allow swapping in multiple different workspace backends to enable this in a more easy to use way.

Detailed Proposal

  1. Add some new syntax to the --workspace entrypoint to allow specifying different types of workspaces --workspace=docker:. or perhaps with a --workspace-type docker.

  2. Change the Workspace interaction with the schedulers to allow for setting more than one available workspace type per scheduler.

class FooScheduler(Scheduler):
    WORKSPACES: Iterable[Workspace] = (DockerWorkspace, DirWorkspace)
  1. Update runner to be aware of the new workspace selectors

Alternatives

Additional context/links

@d4l3k d4l3k added enhancement New feature or request module: runner issues related to the torchx.runner and torchx.scheduler modules labels Aug 25, 2022
@kurman
Copy link
Contributor

kurman commented Aug 25, 2022

Will workspace still be synonymous with a 'patch' here?

@d4l3k
Copy link
Member Author

d4l3k commented Aug 25, 2022

Yeah -- would be. Just allows for different types of images/patching with the same scheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module: runner issues related to the torchx.runner and torchx.scheduler modules
Projects
None yet
Development

No branches or pull requests

2 participants