Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid bare except: in stdlib #125522

Open
iritkatriel opened this issue Oct 15, 2024 · 0 comments
Open

avoid bare except: in stdlib #125522

iritkatriel opened this issue Oct 15, 2024 · 0 comments
Labels
stdlib Python modules in the Lib dir

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Oct 15, 2024 •
edited by bedevere-app bot
Loading

Bare excepts are best avoided, this issue is to reduce their use in the stdlib. It is not the intention to blindly replace them by except BaseException:, or to religiously purge all of them, but just to review them and avoid where it's feasible to do so.

(see also #125514).

Linked PRs
@bedevere-app bedevere-app bot mentioned this issue Oct 15, 2024
Merged
@ZeroIntensity ZeroIntensity added the stdlib Python modules in the Lib dir label Oct 15, 2024
iritkatriel added a commit that referenced this issue Oct 15, 2024
@iritkatriel
gh-125522 : add explicit exception types to bare excepts in tests (#1…
e97910c 
…25523)
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Oct 15, 2024
@iritkatriel
pythongh-125522: rewrite test_math.testTan to clarify intention
1340811
@bedevere-app bedevere-app bot mentioned this issue Oct 15, 2024
Merged
iritkatriel added a commit that referenced this issue Oct 19, 2024
@iritkatriel
gh-125522: Fix bare except in test_math.testTan (#125544)
4b421e8
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 19, 2024
@iritkatriel @miss-islington
pythongh-125522: Fix bare except in test_math.testTan (pythonGH-125544)
1309a0a 
(cherry picked from commit 4b421e8)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Oct 19, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 19, 2024
@iritkatriel @miss-islington
pythongh-125522: Fix bare except in test_math.testTan (pythonGH-125544)
11114c8 
(cherry picked from commit 4b421e8)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Oct 19, 2024
Merged
iritkatriel added a commit that referenced this issue Oct 19, 2024
@miss-islington @iritkatriel
[3.12] gh-125522: Fix bare except in test_math.testTan (GH-125544) (#…
5f6e112 
…125727)

gh-125522: Fix bare except in test_math.testTan (GH-125544)
(cherry picked from commit 4b421e8)

Co-authored-by: Irit Katriel <[email protected]>
iritkatriel added a commit that referenced this issue Oct 19, 2024
@miss-islington @iritkatriel
[3.13] gh-125522: Fix bare except in test_math.testTan (GH-125544) (#…
96db216 
…125726)

gh-125522: Fix bare except in test_math.testTan (GH-125544)
(cherry picked from commit 4b421e8)

Co-authored-by: Irit Katriel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iritkatriel @ZeroIntensity