Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tuple C-API docs with better error info #123254

Closed
sobolevn opened this issue Aug 23, 2024 · 0 comments
Closed

Improve tuple C-API docs with better error info #123254

sobolevn opened this issue Aug 23, 2024 · 0 comments
Assignees
@sobolevn
Labels
docs Documentation in the Doc dir topic-C-API

Comments

@sobolevn
Copy link
Member

sobolevn commented Aug 23, 2024 •
edited by bedevere-app bot
Loading

There are multiple functions which do not declare:

  • That they can return NULL
  • That they also set an exception on error

I will send a PR.

Linked PRs
@sobolevn sobolevn added docs Documentation in the Doc dir topic-C-API labels Aug 23, 2024
@sobolevn sobolevn self-assigned this Aug 23, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Aug 23, 2024
@sobolevn
pythongh-123254: Improve tuple CAPI docs with more info about errors
ff91f08
@bedevere-app bedevere-app bot mentioned this issue Aug 23, 2024
Merged
sobolevn added a commit that referenced this issue Aug 28, 2024
@sobolevn @erlend-aasland
gh-123254: Improve tuple C API docs with more info about errors (#1…
6f563e3 
…23255)

Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 28, 2024
@sobolevn @erlend-aasland @miss-islington
pythongh-123254: Improve tuple C API docs with more info about erro…
07356c4 
…rs (pythonGH-123255)

(cherry picked from commit 6f563e3)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 28, 2024
@sobolevn @erlend-aasland @miss-islington
pythongh-123254: Improve tuple C API docs with more info about erro…
ca0b67d 
…rs (pythonGH-123255)

(cherry picked from commit 6f563e3)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
This was referenced Aug 28, 2024
Merged
Merged
sobolevn added a commit that referenced this issue Aug 28, 2024
@miss-islington @sobolevn @erlend-aasland
[3.12] gh-123254: Improve tuple C API docs with more info about err…
248af25 
…ors (GH-123255) (#123415)

gh-123254: Improve `tuple` C API docs with more info about errors (GH-123255)
(cherry picked from commit 6f563e3)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
sobolevn added a commit that referenced this issue Aug 28, 2024
@miss-islington @sobolevn @erlend-aasland
[3.13] gh-123254: Improve tuple C API docs with more info about err…
fbc9752 
…ors (GH-123255) (#123416)

gh-123254: Improve `tuple` C API docs with more info about errors (GH-123255)
(cherry picked from commit 6f563e3)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
docs Documentation in the Doc dir topic-C-API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn