New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can i commit my new feature: whitelist? #48

Closed

andreabisello opened this issue May 30, 2016 · 1 comment

andreabisello commented May 30, 2016

hi,

sometime i needed to remove something inside my screenshot div because sometime some changes can be considered normal.

e.g. i have a dashboard with some graphs, i need to make a visual comparison of the dashboard but changes in graph can be normal.

so i updated the library and now assertScreenshot can take a whitelist of css selector as parameters.

can i commit my update?

thanks

Collaborator

jphalip commented May 30, 2016

Thanks for the suggestion. There's no need to open a separate ticket, so I'm going to close this one. I've left some comments in the PR #49.

jphalip closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment