Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO overhaul #38

Closed
decahedron1 opened this issue Apr 6, 2023 Discussed in #37 · 0 comments
Closed

IO overhaul #38

decahedron1 opened this issue Apr 6, 2023 Discussed in #37 · 0 comments
Assignees
Labels
enhancement New feature or request p: high high priority

Comments

@decahedron1
Copy link
Member

Session inputs/outputs should probably be reworked. The way they work now is a bit messy for my liking, and there is currently no clear path for supporting important features like IOBinding or non-tensor types.

A few things I think should be addressed:

Allocate outside of run function: Discussed in #37

Originally posted by stexa April 6, 2023
Hey!
For the usage in audio processes and in general for the performance it would be really nice if the inputs and outputs could be set and allocated before the actual run() function. Somewhat like suggested here:
nbigaouette/onnxruntime-rs#41

This could be an additional function as well. Might this be something you would be interested in as well?

And thank you, I am very happy that someone is still working on a onnxruntime wrapper in rust, the crate is working out of the box like a charm for me :)

IOBinding: Discussed in #15

Originally posted by dzhao January 30, 2023
Hi, do you plan to support IOBiding for cuda/tensorrt?
https://stackoverflow.com/questions/70740287/onnxruntime-inference-is-way-slower-than-pytorch-on-gpu

This seems a critical feature for gpu serving.

@decahedron1 decahedron1 added the enhancement New feature or request label Apr 6, 2023
@decahedron1 decahedron1 self-assigned this Apr 6, 2023
@decahedron1 decahedron1 mentioned this issue Apr 11, 2023
8 tasks
@decahedron1 decahedron1 added the p: high high priority label Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p: high high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant