-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text Open file in always localized in english (Android) #331
Comments
I've been investigating and I found that this text is hardcoded in the FileOpener2.java:141. The fastest "solution" would be to fork the plugin and change the text but that doesn't solve the case where the app is multilanguage. Any ideas on how this text could be sent translated in the current language from the app to the plugin without breaking the ionic interface? |
hi @JaviManteiga. Thank you for raising this issue. Unfortunately there are no plans to support other languages with this plugin, but we would be happy to accept a PR. |
@JaviManteiga Can you provide me your solution code to open pdf file in android using ionic ? |
I'm not using that function. My code is similar to the example in the docs https://github.com/pwlin/cordova-plugin-file-opener2?tab=readme-ov-file#quick-example |
I'm working on a Ionic + cordova project and I use this plugin to open PDFs in Android (with the method showOpenWithDialog of the awesome-cordova-plugins) but when the dialog opens to choose which app you want to open the file with, the header text (Open file in) is always in english. However the cancel button works as expected. I've seen this issue regarding the same problem in iOS but the solution is not applicable to Android. Is this a bug? am I missing something?
Thanks in advance
The text was updated successfully, but these errors were encountered: