Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] #4821

Open
RenatoRolando opened this issue Oct 1, 2024 · 7 comments
Open

[BUG] #4821

RenatoRolando opened this issue Oct 1, 2024 · 7 comments
Labels
bug 🐛 needs attention 👋 needs triage 🔍

Comments

@RenatoRolando
Copy link

RenatoRolando commented Oct 1, 2024 •
edited
Loading

What happened?

pswabuilder.com froozen in inspect this pwa ([https://circolari.quifederfarma.it/]) with webmanifest wrong

How do we reproduce the behavior?

  1. go. to website pwabuilder
  2. chech https://www.pwabuilder.com/
  3. this site have a wrong manifest.webmanifest (see below)

Check this website, actually I have the manifest.webmanifest like this, but I will change to fix it .

</html><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"/>
<title>404 - Impossibile trovare il file o la directory.</title>
<style type="text/css">
<!--
body{margin:0;font-size:.7em;font-family:Verdana, Arial, Helvetica, sans-serif;background:#EEEEEE;}
fieldset{padding:0 15px 10px 15px;} 
h1{font-size:2.4em;margin:0;color:#FFF;}
h2{font-size:1.7em;margin:0;color:#CC0000;} 
h3{font-size:1.2em;margin:10px 0 0 0;color:#000000;} 
#header{width:96%;margin:0 0 0 0;padding:6px 2% 6px 2%;font-family:"trebuchet MS", Verdana, sans-serif;color:#FFF;
background-color:#555555;}
#content{margin:0 0 0 2%;position:relative;}
.content-container{background:#FFF;width:96%;margin-top:8px;padding:10px;position:relative;}
-->
</style>
</head>
<body>
<div id="header"><h1>Errore del server</h1></div>
<div id="content">
 <div class="content-container"><fieldset>
  <h2>404 - Impossibile trovare il file o la directory.</h2>
  <h3>È possibile che la risorsa desiderata sia stata rimossa, che sia temporaneamente non disponibile o che il relativo nome sia stato modificato.</h3>
 </fieldset></div>
</div>
</body>
</html>

pwabuilder never send a report, stay 'frozen'

What do you expect to happen?

pwabuilder should report that the webmanifest is wrong

What environment were you using?

OS Sequoia 15.0, Chrome version 129.0.6668.60

Additional context

No response
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@maiconcarraro
Copy link
Contributor

maiconcarraro commented Oct 8, 2024 •
edited
Loading

@RenatoRolando I was testing your link, the webmanifest seems correct ✅
image

But your service worker is wrong ❌
image
image

Still a different discussion about handling the "infinite loop" (or frozen if thats what you mean), in case you want to fix from your side... you need to have a valid service worker url.

@RenatoRolando
Copy link
Author

@maiconcarraro thank you for your precious help.

At present the pwabuilder, testing my pwa address, is still on 'infitine loop' and obviously doesn't report nothing.
In my opinion is not a valid behavior: the correct solution from the website was report the problem as you present me. At least report that I don't have a service worker.

Renato

@jgw96
Copy link
Contributor

jgw96 commented Oct 10, 2024

Hey all! So the "infinite loading" is a bug on our end when a manifest is not able to be parsed. The problem here is, in your web manifest, you have a line commented out as my screenshot shows. Because of this, PWABuilder is not able to successfully parse the manifest as JSON leading to the issue. While the SW may have also been incorrect, that is not what was causing the issue here from what I can tell. @RenatoRolando , would you be able to update this manifest please to remove the commented line my screenshot points too and try again? I am going to keep this issue open anyways to address our UI issue here, but yeah Id love to be able to try your app again with the commented line removed (or un-commented out)
image

@RenatoRolando
Copy link
Author

@jgw96 Today I will remove the commented line on manifest. Thank for support.
R

@jgw96
Copy link
Contributor

jgw96 commented Oct 15, 2024

@RenatoRolando hey! Any updates here?

@RenatoRolando
Copy link
Author

Dear @RenatoRolando as I told you I have removed the comment line on manifest 5 and now works.
I'm not able to see if still goes on 'infinity loop'. ;)
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 needs attention 👋 needs triage 🔍
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgw96 @maiconcarraro @RenatoRolando