[Feature Request]: Warn user about missing feature

[przepompownia]

I found (by inspecting the code of both sides) that vscode-php-debug does not support variable completion yet. The documentation of this adapter does not mention explicitly about it. On the other side Vimspector silently returns an empty result in such case.

Please warn user about missing feature (echomsg with echohl for example).

vimspector/python3/vimspector/debug_session.py

Lines 631 to 632 in 4e04a86

	if not self._server_capabilities.get( 'supportsCompletionsRequest' ):
	return []

[puremourning]

I’m not sure about this. What is the user supposed to do in response to the warning? Well there isn’t anything they can do. The result is that there are no completions available. Which is true whatever the reason for that.

I mean feel free to try it, but I’m not sure spamming the user with warning they can’t actually fix is such a great solution.

[przepompownia]

What do you think about creating a separate command to display summary of supported and unsupported features for given debug adapter?

See the output from:checkhealth nvim_treesitter for example (from https://github.com/nvim-treesitter/nvim-treesitter):

[puremourning]

Funny I was actually thinking about exactly that recently for a different reason. I have an idea for this to create a VimspectorDebugInfo command (like YcmDebugInfo) that does some diagnostics, which would include printing the server capabilities.

[przepompownia]

From a beginner's (in this topic) point of view it could save time needed to ensure that some disability comes from a missing feature and it is neither Vimspector nor nvim/vim bug.

[przepompownia]

I didn't notified by GitHub about #406 before it was merged.

Thanks. Info about supportsCompletionsRequest still remains missing.

--------------------------------------------------------------------------------
Server Capabilities: 
--------------------------------------------------------------------------------
{
  "supportsConfigurationDoneRequest": true,
  "supportsEvaluateForHovers": false,
  "supportsConditionalBreakpoints": true,
  "supportsFunctionBreakpoints": true,
  "exceptionBreakpointFilters": [
    {
      "filter": "Notice",
      "label": "Notices"
    },
    {
      "filter": "Warning",
      "label": "Warnings"
    },
    {
      "filter": "Error",
      "label": "Errors"
    },
    {
      "filter": "Exception",
      "label": "Exceptions"
    },
    {
      "filter": "*",
      "label": "Everything",
      "default": true
    }
  ],
  "supportTerminateDebuggee": true
}
--------------------------------------------------------------------------------

[puremourning]

Missing means ‘false’

[przepompownia]

There is no "supportsCompletionsRequest": false. I guess this capability isn't reported by PHP XDebug adapter explicitly.

[puremourning]

Exactly. If the entry is not there, it means the adapter doesn't support it.

[przepompownia]

Less advanced users (and me in case of possibly other capabilities) can be still confused as to why, for example, completion does not work (without browsing the code of Vimspector and the adapter).

It would be good to list all the capabilities supported by Vimspector.

[puremourning]

it's a bunch of work that is quite low value imo, but I've added it to the backlog anyway