Invalid filenames for windows should not prevent the usage of a module

[c33s]

if you install puppet/network version 0.9.0 https://github.com/voxpupuli/puppet-network/tree/v0.9.0 on windows with r10k puppetfile install this leads to the following error

ERROR    -> No such file or directory @ rb_file_s_stat - C:/Users/user/AppData/Local/Temp/d20180529-9172-1m9q41f/puppet-network-0.9.0/puppet-network-0.9.0/spec/fixtures/provider/network_config/redhat_spec/network-scripts/ifcfg-eth0:10000000

this is because the module, in this case the fixture files contain invalid filenames for windows voxpupuli/puppet-network#224 it would be a good thing to show only a warning and just skip the file. it is a sad thing that the whole module cannot be used just because of redhat fixtures, while i won't run tests and will deploy to debian :(

[binford2k]

I'm not convinced that's a good idea. In this case, ignoring the error would be relatively benign, but what if the file that didn't write properly was actually a core part of the module's code? The requested change would delay the error from deploy time (when it's relatively benign to catch and correct) to runtime, when puppet runs could fail.

[github-actions]

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

[c33s]

not stale

@binford2k well simply not allowing to use a module is even more unhandy. at least it sould be allowed to use some kind of --force

[github-actions]

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

[c33s]

not stale

[mwaggett]

@c33s We recently added an exclude_spec config option for skipping the deployment of module spec directories. Could you try setting that and then let us know whether you're able to use the offending module now? See these docs for more info on the setting.

[github-actions]

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.