(SUP-3714) check console cert for expiration #168
Closed
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr is to allow for collaboration, this method is filled with holes! and this one is actually harder than it looks Ideally we would ask the server: openssl s_client -servername localhost -connect localhost:443 2>/dev/null | openssl x509 -noout -dates Except on FIPS we cant use the openssl client so that means we can-not do this. Unless we skip on FIPS enabled systems? |
|
Hmm unless we use the ruby library for the remote connection, maybe it will work the same way it allows for static file parsing |
|
We can get the location of the SSL cert from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit checks the default location of the console cert and does the usual expiration check:
Flaws with this method:
console cert file may be present and not in use resulting in false readings
does not work if custom cert location exists