-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support docker-compose-plugin
as provider for docker_compose
resource
#891
Comments
This should be focused. According to the `documentation docker-compose v1 is going to loose support after june 2023. |
@kenyon I am currently working on this. |
@vegaaz since v1 is unsupported upstream, removing support in this module would be 👍 from me. |
docker-ce ships with a version of docker-compise on /usr/libexec/docker/cli-plugins/docker-compose So all that needs to be done is adjust the default path used by the docker_compose resource |
|
Also, at least with Ubuntu and Red Hat packages provided by Docker, |
Ok, the docker-compose is installed by the docker-compose-plugin package, not docker-ce itself. How do we get the module to use it if we dont change the path. |
I checked the upstream documentation, which recommends installing the plugin package. But even when you do that, the module doesnt use it. |
That's the point of this issue. The module needs to be updated so that it uses |
A temporary solution that works for my use case is adding a script that redirects to compose plugin : file { '/usr/bin/docker-compose':
ensure => file,
mode => '0755',
content => 'docker compose "$@"',
}
docker_compose { 'my_compose':
...
} |
This should have been closed with the merge of #975. |
Use Case
The
docker_compose
resource in this module should support the Docker Compose plugin.Describe the Solution You Would Like
The
docker_compose
resource uses docker-compose-plugin rather than failing withError: Could not find a suitable provider for docker_compose
.Describe Alternatives You've Considered
Installing standalone Docker Compose would be an alternative, but that is not supported by upstream per https://docs.docker.com/compose/install/ and upstream provides
docker-compose-plugin
as packages per https://docs.docker.com/compose/install/linux/.Additional Context
See also: #839
The text was updated successfully, but these errors were encountered: