Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency on phpoffice/phpspreadsheet in 2.6.3 #51

Open
kdambekalns opened this issue Sep 19, 2022 · 1 comment
Open

Missing dependency on phpoffice/phpspreadsheet in 2.6.3 #51

kdambekalns opened this issue Sep 19, 2022 · 1 comment

Comments

@kdambekalns
Copy link
Contributor

This is what packagist knows about 2.6.2:

image

And this is what packagist knows about 2.6.3:

image

The reason is tagging on the wrong branch…

@kdambekalns
Copy link
Contributor Author

This has happened (in similar form) with 2.5.2, which was released from 2.0 and later superseded by 2.5.3 from the 2.5 branch.

2.6.0, 2.6.1 and 2.6.2 were released from master, but 2.6.3 from 2.0.

Reason was (as it seems) the merge of #38 into 2.0 and not realising that 2.0 was no longer active. So 2.0 should then have been merged into 2.5. Then a release of 2.5.4 from 2.5 would have been good. Another upmerge into master, release 2.6.3 from there.

Bottom line: what is 3.0.0 should be 2.6.3 🤷‍♂️

To fix this…

Optionally delete the 2.0, 2.5 (and 2.6) branches to avoid such confusion in the future. If needed a 2.x branch can be created "for future use"… 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant