Fix bigquery table replace hitting "already exists" issue #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
VenelinMartinov
changed the base branch from
master
to
vvm/update_providertestr
|
Seems reasonable, especially since BigQuery Tables seem to be a bit more about supporting the analytics world where liveness guarantees are less of a problem presumably than transactional databases. A bit drastic but the underlying resource lifecycle seemed completely not working right before so this looks like a good default. |
t0yv0
approved these changes
Oct 3, 2024
|
We've been using this for structural resources in AWS quite extensively - we don't really have much better options for resource like this = ( |
|
This PR has been shipped in release v8.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bigquery materialized views on tables seem to be structural, so due to pulumi/pulumi#918 the normal pulumi replace of creating and then deleting does not work.
This PR enables DeleteBeforeRelace by default for the resource, fixing the issue.
fixes #2491