Labels do not import cleanly

[iwahbe]

Describe what happened

I expect that refresh works well with unmanaged labels.

We should be able to run for the sample program pulumi up --yes && pulumi refresh --yes && pulumi preview --expect-no-changes.

Sample program

import * as pulumi from "@pulumi/pulumi";
import * as gcp from "@pulumi/gcp";
import { local } from "@pulumi/command";

const gcpConfig = new pulumi.Config("gcp");

const provider = new gcp.Provider("provider", {
  project: gcpConfig.require("project"),
  region: gcpConfig.require("region"),
  defaultLabels: {
    "default-empty": "",
  },
});

const r = new gcp.kms.KeyRing("ring", {
  location: "us-east1",
}, {provider});

const k = new gcp.kms.CryptoKey("key", {
  keyRing: r.id,
  labels: {
    "static": "value",
    //    "empty": "",
  },
}, {deletedWith: r, provider});

export const create = pulumi.interpolate`gcloud kms keys update ${k.id} --keyring=${r.id} --update-labels=unmanaged=value,unmanaged_empty=`;

new local.Command("cmd", {
  create,
}, { deletedWith: k });

export const labels =  k.labels;
export const pulumiLabels = pulumi.unsecret(k.pulumiLabels);
export const effectiveLabels = pulumi.unsecret(k.effectiveLabels);

Log output

NA

Affected Resource(s)

No response

Output of pulumi about

NA

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[VenelinMartinov]

Which bit does not work here?

[VenelinMartinov]

Also is this different with storage Bucket? If so, then this might be a duplicate of #1959

[iwahbe]

When we run the normal cycle, we see that pulumi refresh --yes doesn't generate any diff. When the refresh runs (--yes), no changes are shown but the next pulumi up will add the missing unmanaged labels to effectiveLabels.

This is primarily about the refresh behavior, so it is not a duplicate of #1959.

[VenelinMartinov]

Does that happen without the refresh? AFAIK up actually does an implicit Read of the labels on the cloud resource

[VenelinMartinov]

Either way, this doesn't seem like a huge issue to me - effectiveLabels is meant to represent the actual labels on the resource, so it is expected to change when unmanaged labels change.

[iwahbe]

Does that happen without the refresh? AFAIK up actually does an implicit Read of the labels on the cloud resource

Only with refresh.

Either way, this doesn't seem like a huge issue to me - effectiveLabels is meant to represent the actual labels on the resource, so it is expected to change when unmanaged labels change.

pulumi up --yes && pulumi refresh --yes && pulumi preview --expect-no-changes should always succeed. In the case of the above, the refresh should show a diff (but doesn't) and the second update shouldn't have a diff (but it has the diff that refresh should have had).

The final result is correct, but the order is very wrong.